linux-kernel - Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Mar 2021 03:07:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Václav Kubernát <kubernat@...net.cz>
Cc:     kbuild-all@...ts.01.org,
        Václav Kubernát <kubernat@...net.cz>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
        linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

Hi "Václav,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/V-clav-Kubern-t/hwmon-Add-driver-for-fsp-3y-PSUs-and-PDUs/20210329-224216
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/48af68da782edb21e107a884db98beedfd691e81
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review V-clav-Kubern-t/hwmon-Add-driver-for-fsp-3y-PSUs-and-PDUs/20210329-224216
        git checkout 48af68da782edb21e107a884db98beedfd691e81
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/hwmon/pmbus/fsp-3y.c:15:25: error: array index in initializer exceeds array bounds
      15 | #define YM2151_PAGE_5V  0x20
         |                         ^~~~
   drivers/hwmon/pmbus/fsp-3y.c:114:9: note: in expansion of macro 'YM2151_PAGE_5V'
     114 |   .func[YM2151_PAGE_5V] =
         |         ^~~~~~~~~~~~~~
   drivers/hwmon/pmbus/fsp-3y.c:15:25: note: (near initialization for 'fsp3y_info[0].func')
      15 | #define YM2151_PAGE_5V  0x20
         |                         ^~~~
   drivers/hwmon/pmbus/fsp-3y.c:114:9: note: in expansion of macro 'YM2151_PAGE_5V'
     114 |   .func[YM2151_PAGE_5V] =
         |         ^~~~~~~~~~~~~~
   In file included from include/linux/bits.h:6,
                    from include/linux/bitops.h:6,
                    from include/linux/kernel.h:11,
                    from drivers/hwmon/pmbus/fsp-3y.c:8:
>> include/vdso/bits.h:7:19: warning: initialized field overwritten [-Woverride-init]
       7 | #define BIT(nr)   (UL(1) << (nr))
         |                   ^
   drivers/hwmon/pmbus/pmbus.h:383:26: note: in expansion of macro 'BIT'
     383 | #define PMBUS_HAVE_VOUT  BIT(2)
         |                          ^~~
   drivers/hwmon/pmbus/fsp-3y.c:115:4: note: in expansion of macro 'PMBUS_HAVE_VOUT'
     115 |    PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT,
         |    ^~~~~~~~~~~~~~~
   include/vdso/bits.h:7:19: note: (near initialization for 'fsp3y_info[0].func[0]')
       7 | #define BIT(nr)   (UL(1) << (nr))
         |                   ^
   drivers/hwmon/pmbus/pmbus.h:383:26: note: in expansion of macro 'BIT'
     383 | #define PMBUS_HAVE_VOUT  BIT(2)
         |                          ^~~
   drivers/hwmon/pmbus/fsp-3y.c:115:4: note: in expansion of macro 'PMBUS_HAVE_VOUT'
     115 |    PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT,
         |    ^~~~~~~~~~~~~~~


vim +7 include/vdso/bits.h

3945ff37d2f48d Vincenzo Frascino 2020-03-20  6  
3945ff37d2f48d Vincenzo Frascino 2020-03-20 @7  #define BIT(nr)			(UL(1) << (nr))
3945ff37d2f48d Vincenzo Frascino 2020-03-20  8  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (59879 bytes)