[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <161704647819.3012082.13027529193947275446@swboyd.mtv.corp.google.com>
Date: Mon, 29 Mar 2021 12:34:38 -0700
From: Stephen Boyd <swboyd@...omium.org>
To: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Souradeep Chowdhury <schowdhu@...eaurora.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
Sibi Sankar <sibis@...eaurora.org>,
Rajendra Nayak <rnayak@...eaurora.org>, vkoul@...nel.org,
Souradeep Chowdhury <schowdhu@...eaurora.org>
Subject: Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC
Quoting Souradeep Chowdhury (2021-03-25 01:02:32)
> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> new file mode 100644
> index 0000000..c6e0a9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Data Capture and Compare
> +
> +maintainers:
> + - Souradeep Chowdhury <schowdhu@...eaurora.org>
> +
> +description: |
> + DCC (Data Capture and Compare) is a DMA engine which is used to save
> + configuration data or system memory contents during catastrophic failure
> + or SW trigger.DCC is used to capture and store data for debugging purpose
Add space between trigger. and DCC?
> +
> +
Drop double newline?
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,sm8150-dcc
> + - const: qcom,dcc
> +
> + reg:
> + items:
> + - description: DCC base register region
> + - description: DCC RAM base register region
> +
> + reg-names:
> + items:
> + - const: dcc
> + - const: dcc-ram
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
Do we really need reg names? Seems like we can assume the ordering.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dcc@...2000{
dma@...2000? Or debug@...2000?
> + compatible = "qcom,sm8150-dcc","qcom,dcc";
> + reg = <0x010a2000 0x1000>,
> + <0x010ad000 0x2000>;
> + reg-names = "dcc", "dcc-ram";
> + };
Powered by blists - more mailing lists