linux-kernel - RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB4746BFA99998CD92D43521BAF17E9@DB9PR10MB4746.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 29 Mar 2021 08:00:31 +0000
From:   Arnaud POULIQUEN <arnaud.pouliquen@...com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "tiwai@...e.de" <tiwai@...e.de>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes

Hi,

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Sent: vendredi 26 mars 2021 22:59
> To: alsa-devel@...a-project.org
> Cc: tiwai@...e.de; broonie@...nel.org; linux-kernel@...r.kernel.org; Pierre-
> Louis Bossart <pierre-louis.bossart@...ux.intel.com>; Arnaud POULIQUEN
> <arnaud.pouliquen@...com>; Liam Girdwood <lgirdwood@...il.com>;
> Jaroslav Kysela <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>
> Subject: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes
> 
> cppcheck warning:
> 
> sound/soc/sti/uniperif_player.c:1049:24: style:inconclusive: Function
> 'uni_player_init' argument 2 names different: declaration 'uni_player'
> definition 'player'. [funcArgNamesDifferent]
>       struct uniperif *player)
>                        ^
> sound/soc/sti/uniperif.h:1375:24: note: Function 'uni_player_init'
> argument 2 names different: declaration 'uni_player' definition 'player'.
>       struct uniperif *uni_player);
>                        ^
> sound/soc/sti/uniperif_player.c:1049:24: note: Function 'uni_player_init'
> argument 2 names different: declaration 'uni_player'
> definition 'player'.
>       struct uniperif *player)
>                        ^
> sound/soc/sti/uniperif_reader.c:411:24: style:inconclusive: Function
> 'uni_reader_init' argument 2 names different: declaration 'uni_reader'
> definition 'reader'. [funcArgNamesDifferent]
>       struct uniperif *reader)
>                        ^
> sound/soc/sti/uniperif.h:1380:24: note: Function 'uni_reader_init'
> argument 2 names different: declaration 'uni_reader' definition 'reader'.
>       struct uniperif *uni_reader);
>                        ^
> sound/soc/sti/uniperif_reader.c:411:24: note: Function 'uni_reader_init'
> argument 2 names different: declaration 'uni_reader'
> definition 'reader'.
>       struct uniperif *reader)
>                        ^
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@...com>

Thanks
Arnaud

> ---
>  sound/soc/sti/uniperif.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index
> a16adeb7c1e9..2a5de328501c 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1372,12 +1372,12 @@ static __maybe_unused const struct
> snd_pcm_hardware uni_tdm_hw = {
> 
>  /* uniperiph player*/
>  int uni_player_init(struct platform_device *pdev,
> -		    struct uniperif *uni_player);
> +		    struct uniperif *player);
>  int uni_player_resume(struct uniperif *player);
> 
>  /* uniperiph reader */
>  int uni_reader_init(struct platform_device *pdev,
> -		    struct uniperif *uni_reader);
> +		    struct uniperif *reader);
> 
>  /* common */
>  int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai,
> --
> 2.25.1