linux-kernel - RE: [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY5PR11MB3893D162A53941A3270A047FCC7E9@BY5PR11MB3893.namprd11.prod.outlook.com>
Date:   Mon, 29 Mar 2021 02:15:59 +0000
From:   "Tan, Ley Foon" <ley.foon.tan@...el.com>
To:     Julian Braha <julianbraha@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "fazilyildiran@...il.com" <fazilyildiran@...il.com>
Subject: RE: [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE



> -----Original Message-----
> From: Julian Braha <julian.braha@...il.com> On Behalf Of Julian Braha
> Sent: Saturday, March 27, 2021 2:56 AM
> To: Tan, Ley Foon <ley.foon.tan@...el.com>
> Cc: linux-kernel@...r.kernel.org; fazilyildiran@...il.com
> Subject: [PATCH] arch: nios2: fix unmet dependency for
> SERIAL_CORE_CONSOLE
> 
> When EARLY_PRINTK is enabled and TTY is disabled, Kbuild gives the
> following warning:
> 
> WARNING: unmet direct dependencies detected for
> SERIAL_CORE_CONSOLE
>   Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - EARLY_PRINTK [=y]
> 
> This is because EARLY_PRINTK selects SERIAL_CORE_CONSOLE without
> selecting or depending on TTY, despite SERIAL_CORE_CONSOLE depending
> on TTY.
> 
> Signed-off-by: Julian Braha <julianbraha@...il.com>
> ---
>  arch/nios2/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug index
> a8bc06e96ef5..f453d5c1fd38 100644
> --- a/arch/nios2/Kconfig.debug
> +++ b/arch/nios2/Kconfig.debug
> @@ -3,6 +3,7 @@
>  config EARLY_PRINTK
>  	bool "Activate early kernel debugging"
>  	default y
> +	depends on TTY
>  	select SERIAL_CORE_CONSOLE
>  	help
>  	  Enable early printk on console
> --
> 2.25.1

Acked-by: Ley Foon Tan <ley.foon.tan@...el.com>