[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210330153534.GF4976@sirena.org.uk>
Date: Tue, 30 Mar 2021 16:35:34 +0100
From: Mark Brown <broonie@...nel.org>
To: "Mukunda,Vijendar" <vijendar.mukunda@....com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
alsa-devel@...a-project.org, shumingf@...ltek.com,
flove@...ltek.com, kent_chen@...ltek.com, jack.yu@...ltek.com,
Alexander.Deucher@....com, Basavaraj.Hiregoudar@....com,
Sunil-kumar.Dommati@....com, Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@....com>,
Arnd Bergmann <arnd@...db.de>,
Akshu Agrawal <akshu.agrawal@....com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Tzung-Bi Shih <tzungbi@...gle.com>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x
machine driver
On Tue, Mar 30, 2021 at 09:12:11PM +0530, Mukunda,Vijendar wrote:
> On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:
> > > static const struct acpi_device_id acp3x_audio_acpi_match[] = {
> > > { "AMDI5682", (unsigned long)&acp3x_5682},
> > > { "AMDI1015", (unsigned long)&acp3x_1015},
> > > + { "AMDP1015", (unsigned long)&acp3x_1015p},
> > This isn't a valid ACPI ID. AMDP does not exist in
...
> > There was a similar issue with Intel platforms using this part, we had
> > to use a different HID.
> Is it okay if i use "AMDI1016" for ALC1015P?
That's valid, though obviously you might regret that later on if someone
releases a CODEC with a 1016 name (equally well ACPI being what it is
there's no good options for naming).
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists