linux-kernel - Re: [PATCH] arch: s390: Remove duplicate struct ccw1 declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Mar 2021 20:39:59 +0200
From:   Vineeth Vijayan <vneethv@...ux.ibm.com>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Julian Wiedmann <jwi@...ux.ibm.com>,
        Alexandra Winter <wintera@...ux.ibm.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] arch: s390: Remove duplicate struct ccw1 declaration

Thank you for the patch.
Acked-by: Vineeth Vijayan <vneethv@...ux.ibm.com>
Heiko/Vasily will pick this up and will be part of the s390-tree patchset.

On 3/30/21 12:56 PM, Wan Jiabing wrote:
> struct ccw1 is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>   arch/s390/include/asm/ccwdev.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/s390/include/asm/ccwdev.h b/arch/s390/include/asm/ccwdev.h
> index 778247bb1d61..d4e90f2ba77e 100644
> --- a/arch/s390/include/asm/ccwdev.h
> +++ b/arch/s390/include/asm/ccwdev.h
> @@ -152,9 +152,6 @@ extern struct ccw_device *get_ccwdev_by_busid(struct ccw_driver *cdrv,
>    * when new devices for its type pop up */
>   extern int  ccw_driver_register   (struct ccw_driver *driver);
>   extern void ccw_driver_unregister (struct ccw_driver *driver);
> -
> -struct ccw1;
> -
>   extern int ccw_device_set_options_mask(struct ccw_device *, unsigned long);
>   extern int ccw_device_set_options(struct ccw_device *, unsigned long);
>   extern void ccw_device_clear_options(struct ccw_device *, unsigned long);