linux-kernel - Re: [PATCH] riscv: kprobes/ftrace: Add recursion protection to the ftrace callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210330153922.29f33262@gandalf.local.home>
Date:   Tue, 30 Mar 2021 15:39:22 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jisheng Zhang <jszhang3@...l.ustc.edu.cn>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Guo Ren <guoren@...ux.alibaba.com>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: kprobes/ftrace: Add recursion protection to the
 ftrace callback

On Tue, 30 Mar 2021 02:14:40 +0800
Jisheng Zhang <jszhang3@...l.ustc.edu.cn> wrote:

> From: Jisheng Zhang <jszhang@...nel.org>
> 
> Currently, the riscv's kprobes(powerred by ftrace) handler is
> preemptible. Futher check indicates we miss something similar as the
> commit c536aa1c5b17 ("kprobes/ftrace: Add recursion protection to the
> ftrace callback"), so do similar modifications as the commit does.
> 
> Fixes: 829adda597fe ("riscv: Add KPROBES_ON_FTRACE supported")
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>

Looks fine to me.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve