[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210330211443.GA326528@robh.at.kernel.org>
Date: Tue, 30 Mar 2021 16:14:44 -0500
From: Rob Herring <robh@...nel.org>
To: Quan Nguyen <quan@...amperecomputing.com>
Cc: Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Lee Jones <lee.jones@...aro.org>,
Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
openbmc@...ts.ozlabs.org,
Open Source Submission <patches@...erecomputing.com>,
Phong Vo <phong@...amperecomputing.com>,
"Thang Q . Nguyen" <thang@...amperecomputing.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add bindings for Ampere Altra
SMPro drivers
On Mon, Mar 29, 2021 at 08:52:35AM +0700, Quan Nguyen wrote:
> Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware
> reference platform with Ampere's Altra Processor family.
>
> Signed-off-by: Quan Nguyen <quan@...amperecomputing.com>
> ---
> .../bindings/hwmon/ampere,ac01-hwmon.yaml | 27 ++++++
> .../devicetree/bindings/mfd/ampere,smpro.yaml | 82 +++++++++++++++++++
> 2 files changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
> new file mode 100644
> index 000000000000..015130a281f4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ampere,ac01-hwmon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hardware monitoring driver for the Ampere Altra SMPro
> +
> +maintainers:
> + - Quan Nguyen <quan@...amperecomputing.com>
> +
> +description: |
> + This module is part of the Ampere Altra SMPro multi-function device. For more
> + details see ../mfd/ampere,smpro.yaml.
> +
> +properties:
> + compatible:
> + enum:
> + - ampere,ac01-hwmon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> diff --git a/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
> new file mode 100644
> index 000000000000..bf789c8a3d7d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ampere,smpro.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ampere Altra SMPro firmware driver
> +
> +maintainers:
> + - Quan Nguyen <quan@...amperecomputing.com>
> +
> +description: |
> + Ampere Altra SMPro firmware may contain different blocks like hardware
> + monitoring, error monitoring and other miscellaneous features.
> +
> +properties:
> + compatible:
> + const: ampere,smpro
Only 1 version of SMPro? Needs to be more specific or provide details on
how the exact version of firmware/hardware is discovered.
> +
> + reg:
> + description:
> + I2C device address.
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^hwmon(@[0-9a-f]+)?$":
> + $ref: ../hwmon/ampere,ac01-hwmon.yaml
> +
> + "^misc(@[0-9a-f]+)?$":
> + type: object
> + description: Ampere Altra SMPro Misc driver
Bindings describe h/w, not drivers.
> + properties:
> + compatible:
> + const: "ampere,ac01-misc"
> +
> + "^errmon(@[0-9a-f]+)?$":
> + type: object
> + description: Ampere Altra SMPro Error Monitor driver
> + properties:
> + compatible:
> + const: "ampere,ac01-errmon"
> +
> +required:
> + - "#address-cells"
> + - "#size-cells"
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + smpro@4f {
> + compatible = "ampere,smpro";
> + reg = <0x4f>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hwmon {
> + compatible = "ampere,ac01-hwmon";
> + };
> +
> + misc {
> + compatible = "ampere,ac01-misc";
> + };
> +
> + errmon {
> + compatible = "ampere,ac01-errmon";
> + };
None of the child nodes have any resources in DT, so you don't need
them in DT.
Rob
Powered by blists - more mailing lists