linux-kernel - Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161707636879.29267.3015658648468166896.b4-ty@oracle.com>
Date:   Mon, 29 Mar 2021 23:54:37 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Manish Rangankar <mrangankar@...vell.com>,
        Nilesh Javali <njavali@...vell.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust

On Wed, 10 Mar 2021 23:16:02 +0100, Rasmus Villemoes wrote:

> Instead of strcpy'ing into a stack buffer, just let additional_notice
> point to a string literal living in .rodata. This is better in a few
> ways:
> 
> - Smaller .text - instead of gcc compiling the strcpys as a bunch of
>   immediate stores (effectively encoding the string literal in the
>   instruction stream), we only pay the price of storing the literal in
>   .rodata.
> 
> [...]

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust
      https://git.kernel.org/mkp/scsi/c/adb253433dc8

-- 
Martin K. Petersen	Oracle Linux Engineering