linux-kernel - Re: [PATCH] mm: gup: remove FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202103301403.u00aVRF6-lkp@intel.com>
Date:   Tue, 30 Mar 2021 14:24:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yang Shi <shy828301@...il.com>, akpm@...ux-foundation.org
Cc:     kbuild-all@...ts.01.org, shy828301@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: gup: remove FOLL_SPLIT

Hi Yang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-linux-mm/master]

url:    https://github.com/0day-ci/linux/commits/Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042
base:   https://github.com/hnaz/linux-mm master
config: s390-randconfig-r032-20210330 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c8563a636718f98af86a3965d94e25b8f2cf2354
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042
        git checkout c8563a636718f98af86a3965d94e25b8f2cf2354
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/s390/mm/gmap.c: In function 'thp_split_mm':
>> arch/s390/mm/gmap.c:2498:27: error: 'FOLL_SPLIT' undeclared (first use in this function); did you mean 'FOLL_PIN'?
    2498 |    follow_page(vma, addr, FOLL_SPLIT);
         |                           ^~~~~~~~~~
         |                           FOLL_PIN
   arch/s390/mm/gmap.c:2498:27: note: each undeclared identifier is reported only once for each function it appears in


vim +2498 arch/s390/mm/gmap.c

0959e168678d2d Janosch Frank      2018-07-17  2487  
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2488  static inline void thp_split_mm(struct mm_struct *mm)
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2489  {
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2490  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2491  	struct vm_area_struct *vma;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2492  	unsigned long addr;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2493  
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2494  	for (vma = mm->mmap; vma != NULL; vma = vma->vm_next) {
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2495  		for (addr = vma->vm_start;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2496  		     addr < vma->vm_end;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2497  		     addr += PAGE_SIZE)
1e133ab296f3ff Martin Schwidefsky 2016-03-08 @2498  			follow_page(vma, addr, FOLL_SPLIT);
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2499  		vma->vm_flags &= ~VM_HUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2500  		vma->vm_flags |= VM_NOHUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2501  	}
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2502  	mm->def_flags |= VM_NOHUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2503  #endif
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2504  }
1e133ab296f3ff Martin Schwidefsky 2016-03-08  2505  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26484 bytes)