linux-kernel - Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210330065341.18074-1-heiko.thiery@gmail.com>
Date:   Tue, 30 Mar 2021 08:53:42 +0200
From:   Heiko Thiery <heiko.thiery@...il.com>
To:     jisheng.zhang@...aptics.com
Cc:     jens.wiklander@...aro.org, linux-kernel@...r.kernel.org,
        linux@...ck-us.net, op-tee@...ts.trustedfirmware.org,
        rostedt@...dmis.org, Heiko Thiery <heiko.thiery@...il.com>
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

> If build kernel without "O=dir", below error will be seen:
> 
> In file included from drivers/tee/optee/optee_trace.h:67,
>                  from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
>    95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>       |                                          ^
> compilation terminated.
> 
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
> 
> Tested with and without "O=dir", both can build successfully.
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints")
Tested-by: Heiko Thiery <heiko.thiery@...il.com>

> ---
>  drivers/tee/optee/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
>  optee-objs += supp.o
>  optee-objs += shm_pool.o
>  optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> -- 
> 2.31.0
> 

Thank you.

-- 
Heiko