linux-kernel - Re: [PATCH v5] arm64: Enable perf events based hard lockup detector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210330083218.22285-1-lecopzer.chen@mediatek.com>
Date:   Tue, 30 Mar 2021 16:32:18 +0800
From:   Lecopzer Chen <lecopzer.chen@...iatek.com>
To:     <lecopzer.chen@...iatek.com>
CC:     <alexandru.elisei@....com>, <catalin.marinas@....com>,
        <daniel.thompson@...aro.org>, <dianders@...omium.org>,
        <lecopzer@...il.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <mark.rutland@....com>,
        <sumit.garg@...aro.org>, <swboyd@...omium.org>, <will@...nel.org>,
        <yj.chiang@...iatek.com>
Subject: Re: [PATCH v5] arm64: Enable perf events based hard lockup detector

> > Hi Will, Mark,
> > 
> > On Fri, 15 Jan 2021 at 17:32, Sumit Garg <sumit.garg@...aro.org> wrote:
> > >
> > > With the recent feature added to enable perf events to use pseudo NMIs
> > > as interrupts on platforms which support GICv3 or later, its now been
> > > possible to enable hard lockup detector (or NMI watchdog) on arm64
> > > platforms. So enable corresponding support.
> > >
> > > One thing to note here is that normally lockup detector is initialized
> > > just after the early initcalls but PMU on arm64 comes up much later as
> > > device_initcall(). So we need to re-initialize lockup detection once
> > > PMU has been initialized.
> > >
> > > Signed-off-by: Sumit Garg <sumit.garg@...aro.org>
> > > ---
> > >
> > > Changes in v5:
> > > - Fix lockup_detector_init() invocation to be rather invoked from CPU
> > >   binded context as it makes heavy use of per-cpu variables and shouldn't
> > >   be invoked from preemptible context.
> > >
> > 
> > Do you have any further comments on this?
> > 
> > Lecopzer,
> > 
> > Does this feature work fine for you now?
> 
> This really fixes the warning, I have a real hardware for testing this now.
> but do we need to call lockup_detector_init() for each cpu?
> 
> In init/main.c, it's only called by cpu 0 for once.
 
Oh sorry, I just misread the code, please ignore previous mail.
 

BRs,
Lecopzer