linux-kernel - Re: [PATCH] nvmem: Change to unified property interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202103301849.HGuL88lx-lkp@intel.com>
Date:   Tue, 30 Mar 2021 18:43:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kevin Paul Herbert <kph@...tinasystems.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     kbuild-all@...ts.01.org, "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org,
        Tom Grennan <tgrennan@...tinasystems.com>,
        linux-kernel@...r.kernel.org,
        Kevin Paul Herbert <kph@...tinasystems.com>
Subject: Re: [PATCH] nvmem: Change to unified property interface

Hi Kevin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e43c377a79f9189fea8f2711b399d4e8b4e609b
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/edbc7632702cf638265a6d7180bd8c951cda6ad9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
        git checkout edbc7632702cf638265a6d7180bd8c951cda6ad9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/thermal/sprd_thermal.c: In function 'sprd_thm_cal_read':
>> drivers/thermal/sprd_thermal.c:128:9: error: implicit declaration of function 'of_nvmem_cell_get'; did you mean 'nvmem_cell_get'? [-Werror=implicit-function-declaration]
     128 |  cell = of_nvmem_cell_get(np, cell_id);
         |         ^~~~~~~~~~~~~~~~~
         |         nvmem_cell_get
   drivers/thermal/sprd_thermal.c:128:7: warning: assignment to 'struct nvmem_cell *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     128 |  cell = of_nvmem_cell_get(np, cell_id);
         |       ^
   cc1: some warnings being treated as errors


vim +128 drivers/thermal/sprd_thermal.c

554fdbaf19b188 Freeman Liu 2020-02-18  120  
554fdbaf19b188 Freeman Liu 2020-02-18  121  static int sprd_thm_cal_read(struct device_node *np, const char *cell_id,
554fdbaf19b188 Freeman Liu 2020-02-18  122  			     u32 *val)
554fdbaf19b188 Freeman Liu 2020-02-18  123  {
554fdbaf19b188 Freeman Liu 2020-02-18  124  	struct nvmem_cell *cell;
554fdbaf19b188 Freeman Liu 2020-02-18  125  	void *buf;
554fdbaf19b188 Freeman Liu 2020-02-18  126  	size_t len;
554fdbaf19b188 Freeman Liu 2020-02-18  127  
554fdbaf19b188 Freeman Liu 2020-02-18 @128  	cell = of_nvmem_cell_get(np, cell_id);
554fdbaf19b188 Freeman Liu 2020-02-18  129  	if (IS_ERR(cell))
554fdbaf19b188 Freeman Liu 2020-02-18  130  		return PTR_ERR(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  131  
554fdbaf19b188 Freeman Liu 2020-02-18  132  	buf = nvmem_cell_read(cell, &len);
554fdbaf19b188 Freeman Liu 2020-02-18  133  	nvmem_cell_put(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  134  	if (IS_ERR(buf))
554fdbaf19b188 Freeman Liu 2020-02-18  135  		return PTR_ERR(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  136  
554fdbaf19b188 Freeman Liu 2020-02-18  137  	if (len > sizeof(u32)) {
554fdbaf19b188 Freeman Liu 2020-02-18  138  		kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  139  		return -EINVAL;
554fdbaf19b188 Freeman Liu 2020-02-18  140  	}
554fdbaf19b188 Freeman Liu 2020-02-18  141  
554fdbaf19b188 Freeman Liu 2020-02-18  142  	memcpy(val, buf, len);
554fdbaf19b188 Freeman Liu 2020-02-18  143  
554fdbaf19b188 Freeman Liu 2020-02-18  144  	kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  145  	return 0;
554fdbaf19b188 Freeman Liu 2020-02-18  146  }
554fdbaf19b188 Freeman Liu 2020-02-18  147  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (70139 bytes)