linux-kernel - Re: Enabling pmbus power control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Mar 2021 12:22:54 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Zev Weiss <zev@...ilderbeest.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        Andrew Jeffery <andrew@...id.au>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: Enabling pmbus power control

On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:

> (and I don't know if the userspace consumer code is appropriate - you
> might want to check with the regulator maintainer on that).

It's not, you should never see this in a production system.

> > first attempt at this ran into problems with all the
> > reg-userspace-consumer instances getting attached to the first
> > regulator device, I think due to all of the regulators ending up under
> > the same name in the global namespace of regulator_map_list.  I worked
> > around that by adding an ID counter to produce a unique name for each,
> > though that changes device names in userspace-visible ways that I'm
> > not sure would be considered OK for backwards compatibility.  (I'm not
> > familiar enough with the regulator code to know if there's a better
> > way of fixing that problem.)  The #if-ing to keep it behind a Kconfig

> Maybe ask that question on the regulator mailing list.

I can't really tell what the issue is here without more context, the
global name list should not be relevant for much in a system that's well
configured so it sounds like it's user error.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)