linux-kernel - Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e388002df6dd121b238918724f3b43637831d2cc.camel@fi.rohmeurope.com>
Date:   Tue, 30 Mar 2021 12:06:43 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>
CC:     linux-power <linux-power@...rohmeurope.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs


On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:
> On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen
> <matti.vaittinen@...rohmeurope.com> wrote:
> > 
> > +struct bd71815_gpio {
> > +       struct gpio_chip chip;
> > +       struct device *dev;
> 
> Wondering why you need this. Is it the same as chip.parent?
> 

This is exactly the reason why I had the comments you objected in the
probe. dev is pointer to the platform device - which should be used for
prints and any potential devm stuff.

chip.parent is the MFD device which provides the regmap access and DT
node.

Best Regards
	Matti Vaittinen