linux-kernel - Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct register operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGMo4K4b9GIUIGu8@lunn.ch>
Date:   Tue, 30 Mar 2021 15:34:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip UNG Driver List <UNGLinuxDriver@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct
 register operations

> > > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro,
> > > +                                    struct sparx5_sd25g28_params *params)
> > >  {
> > > -     struct sparx5_serdes_regval item[] = {
> > 
> > Could you just add const here, and then it is no longer on the stack?
> > 
> >    Andrew
> 
> No it still counts against the stack even as a const structure.

I'm surprised. Maybe it needs static as well?

I'm just thinking you can get a much smaller patch if you don't need
to modify the table, just add additional qualifiers.

   Andrew