linux-kernel - Re: [PATCH v2] pinctrl: bcm: bcm6362: fix warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63f54c37-757d-7eff-f2e5-77ce374185e9@gmail.com>
Date:   Tue, 30 Mar 2021 15:41:00 +0200
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jonas Gorski <jonas.gorski@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: bcm: bcm6362: fix warning

Hi Andy,

El 30/03/2021 a las 12:55, Andy Shevchenko escribió:
> On Tue, Mar 30, 2021 at 1:33 PM Álvaro Fernández Rojas
> <noltari@...il.com> wrote:
>>
>> The current implementation of bcm6362_set_gpio() produces the following
>> warning on x86_64:
>> drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
>> drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>>    503 |        (uint32_t) desc->drv_data, 0);
>>        |        ^
>>
>> Modify the code to make it similar to bcm63268_set_gpio() in order to fix
>> the warning.
> 
> Seems good to me, thanks!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
>> Fixes: 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")
>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
>> ---
> 
> Missed changelog here.

Yes, sorry about that but I added it to v1 patch by mistake... ;D
  v2: use uintptr_t, remove unneeded space and modify put
  regmap_update_bits() call on a single line.

> 
>>   drivers/pinctrl/bcm/pinctrl-bcm6362.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6362.c b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
>> index eb7ec80353e9..40ef495b6301 100644
>> --- a/drivers/pinctrl/bcm/pinctrl-bcm6362.c
>> +++ b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
>> @@ -496,11 +496,11 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
>>   static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
>>   {
>>          const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
>> +       unsigned int basemode = (uintptr_t)desc->drv_data;
>>          unsigned int mask = bcm63xx_bank_pin(pin);
>>
>> -       if (desc->drv_data)
>> -               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
>> -                                  (uint32_t) desc->drv_data, 0);
>> +       if (basemode)
>> +               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode, 0);
>>
>>          if (pin < BCM63XX_BANK_GPIOS) {
>>                  /* base mode 0 => gpio 1 => mux function */
>> --
>> 2.20.1
>>
> 
> 

Best regards,
Álvaro.