linux-kernel - [PATCH] arm64/mm: Fix mapping_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210331182344.47987-1-zackr@vmware.com>
Date:   Wed, 31 Mar 2021 14:23:44 -0400
From:   Zack Rusin <zackr@...are.com>
To:     <linux-kernel@...r.kernel.org>
CC:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: [PATCH] arm64/mm: Fix mapping_dirty_helpers with arm64

The pagetable walk callbacks in mm/mapping_dirty_helpers.c depend
on a set of helpers from which pud_dirty(pud) was missing. I'm
assuming mapping_dirty_helpers weren't used on ARM64 before
because the missing pud_dirty is causing a compilation error.

The drivers/gpu/drm/vmwgfx code uses mapping_dirty_helpers and
has been ported to ARM64 but it depends on this code getting in
first in order to compile/work.

Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Will Deacon <will@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: linux-arm-kernel@...ts.infradead.org
Signed-off-by: Zack Rusin <zackr@...are.com>
---
 arch/arm64/include/asm/pgtable.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
index 47027796c2f9..ecd80f87a996 100644
--- a/arch/arm64/include/asm/pgtable.h
+++ b/arch/arm64/include/asm/pgtable.h
@@ -451,6 +451,7 @@ static inline pmd_t pmd_mkdevmap(pmd_t pmd)
 #define pfn_pmd(pfn,prot)	__pmd(__phys_to_pmd_val((phys_addr_t)(pfn) << PAGE_SHIFT) | pgprot_val(prot))
 #define mk_pmd(page,prot)	pfn_pmd(page_to_pfn(page),prot)
 
+#define pud_dirty(pud)		pte_dirty(pud_pte(pud))
 #define pud_young(pud)		pte_young(pud_pte(pud))
 #define pud_mkyoung(pud)	pte_pud(pte_mkyoung(pud_pte(pud)))
 #define pud_write(pud)		pte_write(pud_pte(pud))
-- 
2.27.0