linux-kernel - Re: [PATCH Resend v0 2/6] dt-bindings: pinctrl: mt8195: add binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1617150743.10316.18.camel@mhfsdcap03>
Date:   Wed, 31 Mar 2021 08:32:23 +0800
From:   zhiyong tao <zhiyong.tao@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <biao.huang@...iatek.com>,
        <linus.walleij@...aro.org>, <hongzhou.yang@...iatek.com>,
        <srv_heupstream@...iatek.com>, <jg_poxu@...iatek.com>,
        <devicetree@...r.kernel.org>, <mark.rutland@....com>,
        <matthias.bgg@...il.com>, <sean.wang@...iatek.com>,
        <linux-gpio@...r.kernel.org>, <erin.lo@...iatek.com>,
        <hui.liu@...iatek.com>, <sean.wang@...nel.org>,
        <sj.huang@...iatek.com>, <eddie.huang@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>, <seiya.wang@...iatek.com>
Subject: Re: [PATCH Resend v0 2/6] dt-bindings: pinctrl: mt8195: add binding
 document

On Tue, 2021-03-30 at 08:39 -0500, Rob Herring wrote:
> On Tue, Mar 30, 2021 at 05:05:28PM +0800, zhiyong tao wrote:
> > On Mon, 2021-03-29 at 14:21 -0500, Rob Herring wrote:
> > > On Mon, 29 Mar 2021 19:30:59 +0800, Zhiyong Tao wrote:
> > > > The commit adds mt8195 compatible node in binding document.
> > > > 
> > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com>
> > > > ---
> > > >  .../bindings/pinctrl/pinctrl-mt8195.yaml      | 152 ++++++++++++++++++
> > > >  1 file changed, 152 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dts:19:18: fatal error: dt-bindings/pinctrl/mt8195-pinfunc.h: No such file or directory
> > >    19 |         #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
> > >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1380: dt_binding_check] Error 2
> > > 
> > > See https://patchwork.ozlabs.org/patch/1459558
> > > 
> > > This check can fail if there are any dependencies. The base for a patch
> > > series is generally the most recent rc1.
> > > 
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > > 
> > > pip3 install dtschema --upgrade
> > > 
> > > Please check and re-submit.
> > > 
> > 
> > ==> I set the patch file "mt8195-pinfunc.h" patch in "4/6". so we should
> > add the file "mt8195-pinfunc.h" in this patch ? or we should put it
> > before this patch(2/6)?
> 
> It is part of the binding, so it belongs in this patch.
> 
> Rob

==> Thanks for your suggestion. We will add it in this patch in next
version.