linux-kernel - Re: [PATCH v3 00/25] KVM SGX virtualization support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGUEWiY3ymVbkk0y@kernel.org>
Date:   Thu, 1 Apr 2021 02:23:06 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     "Huang, Kai" <kai.huang@...el.com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
        "Huang, Haitao" <haitao.huang@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "jethro@...tanix.com" <jethro@...tanix.com>,
        "b.thiel@...teo.de" <b.thiel@...teo.de>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "corbet@....net" <corbet@....net>
Subject: Re: [PATCH v3 00/25] KVM SGX virtualization support

On Sun, Mar 28, 2021 at 09:01:38PM +0000, Huang, Kai wrote:
> > On Fri, Mar 19, 2021 at 08:29:27PM +1300, Kai Huang wrote:
> > > This series adds KVM SGX virtualization support. The first 14 patches
> > > starting with x86/sgx or x86/cpu.. are necessary changes to x86 and
> > > SGX core/driver to support KVM SGX virtualization, while the rest are patches
> > to KVM subsystem.
> > >
> > > This series is based against latest tip/x86/sgx, which has Jarkko's
> > > NUMA allocation support.
> > >
> > > You can also get the code from upstream branch of kvm-sgx repo on github:
> > >
> > >         https://github.com/intel/kvm-sgx.git upstream
> > >
> > > It also requires Qemu changes to create VM with SGX support. You can
> > > find Qemu repo here:
> > >
> > > 	https://github.com/intel/qemu-sgx.git upstream
> > >
> > > Please refer to README.md of above qemu-sgx repo for detail on how to
> > > create guest with SGX support. At meantime, for your quick reference
> > > you can use below command to create SGX guest:
> > >
> > > 	#qemu-system-x86_64 -smp 4 -m 2G -drive
> > file=<your_vm_image>,if=virtio \
> > > 		-cpu host,+sgx_provisionkey \
> > > 		-sgx-epc id=epc1,memdev=mem1 \
> > > 		-object memory-backend-epc,id=mem1,size=64M,prealloc
> > >
> > > Please note that the SGX relevant part is:
> > >
> > > 		-cpu host,+sgx_provisionkey \
> > > 		-sgx-epc id=epc1,memdev=mem1 \
> > > 		-object memory-backend-epc,id=mem1,size=64M,prealloc
> > >
> > > And you can change other parameters of your qemu command based on your
> > needs.
> > 
> > Please also put tested-by from me to all patches (including pure KVM
> > patches):
> > 
> > Tested-by: Jarkko Sakkinen <jarkko@...nel.org>
> > 
> > I did the basic test, i.e. run selftest in a VM. I think that is sufficient at this point.
> > 
> 
> Thanks Jarkko for doing the test!

Sure, have had it in my queue for some time :-)

/Jarkko