linux-kernel - Re: [PATCH 03/12] ARM: omap1: osk: Constify the software node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Mar 2021 09:15:00 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCH 03/12] ARM: omap1: osk: Constify the software node

* Heikki Krogerus <heikki.krogerus@...ux.intel.com> [210329 10:51]:
> Additional device properties are always just a part of a
> software fwnode. If the device properties are constant, the
> software node can also be constant.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Aaro Koskinen <aaro.koskinen@....fi>
> Cc: Tony Lindgren <tony@...mide.com>

Probably best to merge this via the rest of the series:

Acked-by: Tony Lindgren <tony@...mide.com>

> ---
>  arch/arm/mach-omap1/board-osk.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
> index 0a4c9b0b13b0c..e18b6f13300eb 100644
> --- a/arch/arm/mach-omap1/board-osk.c
> +++ b/arch/arm/mach-omap1/board-osk.c
> @@ -332,11 +332,15 @@ static const struct property_entry mistral_at24_properties[] = {
>  	{ }
>  };
>  
> +static const struct software_node mistral_at24_node = {
> +	.properties = mistral_at24_properties,
> +};
> +
>  static struct i2c_board_info __initdata mistral_i2c_board_info[] = {
>  	{
>  		/* NOTE:  powered from LCD supply */
>  		I2C_BOARD_INFO("24c04", 0x50),
> -		.properties = mistral_at24_properties,
> +		.swnode = &mistral_at24_node,
>  	},
>  	/* TODO when driver support is ready:
>  	 *  - optionally ov9640 camera sensor at 0x30
> -- 
> 2.30.2
>