linux-kernel - Re: [PATCH] nds32: flush_dcache_page: use page_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEbi=3fXUnpJDxaWoYtDqmEHDrziR==6-6bvrobaKboBFnLyew@mail.gmail.com>
Date:   Wed, 31 Mar 2021 15:30:51 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Huang Ying <ying.huang@...el.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Nick Hu <nickhu@...estech.com>,
        Vincent Chen <deanbo422@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid
 races with swapoff

Greentime Hu <green.hu@...il.com> 於 2021年3月31日 週三 下午3:30寫道：
>
> Matthew Wilcox <willy@...radead.org> 於 2021年3月31日 週三 上午2:14寫道：
> >
> > On Tue, Mar 30, 2021 at 08:51:26PM +0300, Mike Rapoport wrote:
> > > From: Mike Rapoport <rppt@...ux.ibm.com>
> > >
> > > Commit cb9f753a3731 ("mm: fix races between swapoff and flush dcache")
> > > updated flush_dcache_page implementations on several architectures to use
> > > page_mapping_file() in order to avoid races between page_mapping() and
> > > swapoff().
> > >
> > > This update missed arch/nds32 and there is a possibility of a race there.
> > >
> > > Replace page_mapping() with page_mapping_file() in nds32 implementation of
> > > flush_dcache_page().
> > >
> > > Fixes: cb9f753a3731 ("mm: fix races between swapoff and flush dcache")
> > > Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> >
> > Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>
> Acked-by: Greentiime Hu <green.hu@...il.com>
Typo.
Acked-by: Greentime Hu <green.hu@...il.com>