linux-kernel - Re: [PATCH v5] powerpc/uprobes: Validation for prefixed instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161715297002.226945.13446780395285368488.b4-ty@ellerman.id.au>
Date:   Wed, 31 Mar 2021 12:09:30 +1100
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     mpe@...erman.id.au, Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     naveen.n.rao@...ux.ibm.com, oleg@...hat.com,
        linuxppc-dev@...ts.ozlabs.org, sandipan@...ux.ibm.com,
        jniethe5@...il.com, linux-kernel@...r.kernel.org,
        rostedt@...dmis.org, paulus@...ba.org
Subject: Re: [PATCH v5] powerpc/uprobes: Validation for prefixed instruction

On Thu, 11 Mar 2021 14:45:38 +0530, Ravi Bangoria wrote:
> As per ISA 3.1, prefixed instruction should not cross 64-byte
> boundary. So don't allow Uprobe on such prefixed instruction.
> 
> There are two ways probed instruction is changed in mapped pages.
> First, when Uprobe is activated, it searches for all the relevant
> pages and replace instruction in them. In this case, if that probe
> is on the 64-byte unaligned prefixed instruction, error out
> directly. Second, when Uprobe is already active and user maps a
> relevant page via mmap(), instruction is replaced via mmap() code
> path. But because Uprobe is invalid, entire mmap() operation can
> not be stopped. In this case just print an error and continue.

Applied to powerpc/next.

[1/1] powerpc/uprobes: Validation for prefixed instruction
      https://git.kernel.org/powerpc/c/d943bc742a6aabc578b6b62a713ceedf8bf16623

cheers