linux-kernel - Re: [PATCH -next] staging: rtl8723bs: core: Remove unused variable 'res'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Mar 2021 12:29:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Xu Jia <xujia39@...wei.com>
Cc:     Ross Schmidt <ross.schm.dev@...il.com>,
        Amarjargal Gundjalam <amarjargal16@...il.com>,
        Jason Yan <yanaijie@...wei.com>, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] staging: rtl8723bs: core: Remove unused variable
 'res'

On Wed, Mar 31, 2021 at 04:12:43PM +0800, Xu Jia wrote:
> The variable 'res' is not used in function, this commit
> remove it to fix the warning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Xu Jia <xujia39@...wei.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> index f96dd0b40e04..00b83919a9a3 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> @@ -533,7 +533,6 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)
>  u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
>  {
>  	struct sta_info *psta;
> -	u32 res = _SUCCESS;
>  	NDIS_802_11_MAC_ADDRESS	bcast_addr = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
>  
>  	struct	sta_priv *pstapriv = &padapter->stapriv;
> @@ -542,15 +541,12 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
>  	psta = rtw_alloc_stainfo(pstapriv, bcast_addr);
>  
>  	if (!psta) {
> -		res = _FAIL;
>  		RT_TRACE(_module_rtl871x_sta_mgt_c_, _drv_err_, ("rtw_alloc_stainfo fail"));
> -		goto exit;
> +		return _FAIL;

You just changed the logic here, that's not a good thing for a "robot"
to be doing at all.

greg k-h