linux-kernel - Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <71BBD1B0-FA0A-493D-A1D2-40E7304B0A35@googlemail.com>
Date:   Wed, 31 Mar 2021 15:10:01 +0200
From:   Norman Maurer <norman.maurer@...glemail.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dsahern@...nel.org,
        davem@...emloft.net
Subject: Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ...,
 ...)

Friendly ping… 

As this missing change was most likely an oversight in the original commit I do think it should go into 5.12 and subsequently stable as well. That’s also the reason why I didn’t send a v2 and changed the commit message / subject for the patch. For me it clearly is a bug and not a new feature.


Thanks
Norman


> On 26. Mar 2021, at 13:22, Paolo Abeni <pabeni@...hat.com> wrote:
> 
> On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote:
>> On 26. Mar 2021, at 10:36, Paolo Abeni <pabeni@...hat.com> wrote:
>>> One thing you can do to simplifies the maintainer's life, would be post
>>> a v2 with the correct tag (and ev. obsolete this patch in patchwork).
>> 
>> I am quite new to contribute patches to the kernel so I am not sure
>> how I would “obsolete” this patch and make a v2. If you can give me
>> some pointers I am happy to do so.
> 
> Well, I actually gave you a bad advice about fiddling with patchwork.
> 
> The autoritative documentation:
> 
> Documentation/networking/netdev-FAQ.rst
> 
> (inside the kernel tree) suggests to avoid it.
> 
> Just posting a v2 will suffice.
> 
> Thanks!
> 
> Paolo
>