linux-kernel - Re: [PATCH v1 1/1] driver core: platform: Declare early_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210331152222.GA149339@roeck-us.net>
Date:   Wed, 31 Mar 2021 08:22:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] driver core: platform: Declare
 early_platform_cleanup() prototype

On Wed, Mar 31, 2021 at 06:05:25PM +0300, Andy Shevchenko wrote:
> Compiler is not happy:
> 
>   CC      drivers/base/platform.o
> drivers/base/platform.c:1557:20: warning: no previous prototype for ‘early_platform_cleanup’ [-Wmissing-prototypes]
>  1557 | void __weak __init early_platform_cleanup(void) { }
>       |                    ^~~~~~~~~~~~~~~~~~~~~~
> 
> Declare early_platform_cleanup() prototype in the header to make everyone happy.
> 
> Fixes: eecd37e105f0 ("drivers: Fix boot problem on SuperH")
> Cc: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  include/linux/platform_device.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 3f23f6e430bf..cd81e060863c 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -359,4 +359,7 @@ static inline int is_sh_early_platform_device(struct platform_device *pdev)
>  }
>  #endif /* CONFIG_SUPERH */
>  
> +/* For now only SuperH uses it */
> +void early_platform_cleanup(void);
> +
>  #endif /* _PLATFORM_DEVICE_H_ */
> -- 
> 2.30.2
>