linux-kernel - Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210401154827.2f801300@coco.lan>
Date:   Thu, 1 Apr 2021 15:48:27 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Richard Guy Briggs <rgb@...hat.com>
Cc:     Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Eric Paris <eparis@...isplace.org>,
        Paul Moore <paul@...l-moore.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs <rgb@...hat.com> escreveu:

> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
> 
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
>  Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> 
> diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
> new file mode 100644
> index 000000000000..e7c100b9ab18
> --- /dev/null
> +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> @@ -0,0 +1,15 @@
> +What:		Audit Login UID
> +Date:		2005-02-01
> +KernelVersion:	2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
> +Contact:	linux-audit@...hat.com
> +Format:		%u

The ABI definition doesn't include a "Format:" symbol. See:

	Documentation/ABI/README

For the valid ones.

This change causes a warning at the ABI parser:


	$ ./scripts/get_abi.pl validate
	Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
		tag 'contact' is invalid. Line
			Format:		%u
	Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
		tag 'contact' is invalid. Line
			Format:		%u

You should either drop it or add it to the parser and to the README
file, if the ABI maintainers are ok with such new field.

Thanks,
Mauro