linux-kernel - Re: [PATCH] init: add support for zstd compressed modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <B25BE8E0-14AE-44EA-9A30-F6FED2B6567F@fb.com>
Date:   Thu, 1 Apr 2021 19:18:24 +0000
From:   Nick Terrell <terrelln@...com>
To:     "torvic9@...lbox.org" <torvic9@...lbox.org>
CC:     Piotr Górski <lucjan.lucjanov@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
        "michal.lkml@...kovi.net" <michal.lkml@...kovi.net>
Subject: Re: [PATCH] init: add support for zstd compressed modules



> On Apr 1, 2021, at 12:54 AM, torvic9@...lbox.org wrote:
> 
> Thanks Piotr, good work!
> Question: Is `-T0` really faster in this particular case than the default `-T1`? Are modules installed sequentially?

The zstd CLI produces deterministic output regardless of the number of threads used. `-T1` (or not specifying `-T`) will produce the same output as `-T0`. `-T0` will be faster for large files (at the default level, multiple jobs will be spawned for files > 8MB), and be just as fast as `-T1` for smaller files.

Best,
Nick

> I also saw that Masahiro did some work on modules_install, moving MODULE_COMPRESS from the base Makefile to scripts/Makefile.modinst, so perhaps this should also be moved there at a later point.
> 
> Tor Vic