linux-kernel - RE: [PATCH v2 1/1] use crc32 instead of md5 for hibernation e820 integrity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB0892DC42B3FFA456968E0F24BF7B9@MW2PR2101MB0892.namprd21.prod.outlook.com>
Date:   Thu, 1 Apr 2021 19:50:41 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Chris von Recklinghausen <crecklin@...hat.com>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "simo@...hat.com" <simo@...hat.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] use crc32 instead of md5 for hibernation e820
 integrity check

> From: Chris von Recklinghausen <crecklin@...hat.com>
> Sent: Thursday, April 1, 2021 9:42 AM
> To: ardb@...nel.org; simo@...hat.com; rafael@...nel.org; Dexuan Cui
> <decui@...rosoft.com>; linux-pm@...r.kernel.org;
> linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH v2 1/1] use crc32 instead of md5 for hibernation e820 integrity
> check
> 
> Suspend fails on a system in fips mode because md5 is used for the e820
> integrity check and is not available. Use crc32 instead.
> 
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory
> map
>        by md5 digest")
> Signed-off-by: Chris von Recklinghausen <crecklin@...hat.com>
> ---
>  arch/x86/power/hibernate.c | 35 +++++++++++++++++++----------------
>  1 file changed, 19 insertions(+), 16 deletions(-)

Thanks Chris and all! This patch looks good to me.

Tested-by: Dexuan Cui <decui@...rosoft.com>
Reviewed-by: Dexuan Cui <decui@...rosoft.com>