linux-kernel - Re: [PATCH -next] i2c: gpio: use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Apr 2021 11:38:30 +0800
From:   chenlifu <chenlifu@...wei.com>
To:     Russell King <linux@...linux.org.uk>
CC:     <heying24@...wei.com>, <yuehaibing@...wei.com>,
        <weiyongjun1@...wei.com>, <johnny.chenyi@...wei.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

Kindly pinging ...

Best Regards,
Chen Lifu

在 2021/3/27 17:52, Chen Lifu 写道:
> From: Lifu Chen <chenlifu@...wei.com>
> 
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Lifu Chen <chenlifu@...wei.com>
> ---
>   arch/arm/mach-sa1100/simpad.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index c7fb9a73e4c5..c183432880d3 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -45,7 +45,7 @@
>    */
>   
>   static long cs3_shadow;
> -static spinlock_t cs3_lock;
> +static DEFINE_SPINLOCK(cs3_lock);
>   static struct gpio_chip cs3_gpio;
>   
>   long simpad_get_cs3_ro(void)
> @@ -379,8 +379,6 @@ static int __init simpad_init(void)
>   {
>   	int ret;
>   
> -	spin_lock_init(&cs3_lock);
> -
>   	cs3_gpio.label = "simpad_cs3";
>   	cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
>   	cs3_gpio.ngpio = 24;
> 
> .
>