linux-kernel - Re: [PATCH] overflow: improve check_shl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161731160130.2687418.11028495096127465037.b4-ty@chromium.org>
Date:   Thu,  1 Apr 2021 14:13:24 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Keith Busch <kbusch@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Kees Cook <keescook@...omium.org>, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] overflow: improve check_shl_overflow comment

On Thu, 1 Apr 2021 09:06:29 -0700, Keith Busch wrote:
> A 'false' return means the value was safely set, so the comment should
> say 'true' for when it is not considered safe.

Oops, yes; too many inverse negatives. ;) Applied to for-next/overflow, thanks!

[1/1] overflow: Correct check_shl_overflow() comment
      https://git.kernel.org/kees/c/4578be130a64

-- 
Kees Cook