linux-kernel - Re: [PATCH 09/30] media: atmel: atmel-isc: extract CBC submodule config into separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Apr 2021 05:37:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        devicetree@...r.kernel.org, linux-media@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Eugen Hristev <eugen.hristev@...rochip.com>
Subject: Re: [PATCH 09/30] media: atmel: atmel-isc: extract CBC submodule
 config into separate function

Hi Eugen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eugen-Hristev/media-atmel-atmel-isc-add-support-for-xisc/20210402-024144
base:   git://linuxtv.org/media_tree.git master
config: arm64-randconfig-r024-20210401 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0136fa35e972de936a196a353496986799606b7b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eugen-Hristev/media-atmel-atmel-isc-add-support-for-xisc/20210402-024144
        git checkout 0136fa35e972de936a196a353496986799606b7b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/media/platform/atmel/atmel-sama5d2-isc.c:57:6: warning: no previous prototype for 'isc_sama5d2_config_csc' [-Wmissing-prototypes]
      57 | void isc_sama5d2_config_csc(struct isc_device *isc)
         |      ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/atmel/atmel-sama5d2-isc.c:76:6: warning: no previous prototype for 'isc_sama5d2_config_cbc' [-Wmissing-prototypes]
      76 | void isc_sama5d2_config_cbc(struct isc_device *isc)
         |      ^~~~~~~~~~~~~~~~~~~~~~


vim +/isc_sama5d2_config_cbc +76 drivers/media/platform/atmel/atmel-sama5d2-isc.c

    56	
  > 57	void isc_sama5d2_config_csc(struct isc_device *isc)
    58	{
    59		struct regmap *regmap = isc->regmap;
    60	
    61		/* Convert RGB to YUV */
    62		regmap_write(regmap, ISC_CSC_YR_YG + isc->offsets.csc,
    63			     0x42 | (0x81 << 16));
    64		regmap_write(regmap, ISC_CSC_YB_OY + isc->offsets.csc,
    65			     0x19 | (0x10 << 16));
    66		regmap_write(regmap, ISC_CSC_CBR_CBG + isc->offsets.csc,
    67			     0xFDA | (0xFB6 << 16));
    68		regmap_write(regmap, ISC_CSC_CBB_OCB + isc->offsets.csc,
    69			     0x70 | (0x80 << 16));
    70		regmap_write(regmap, ISC_CSC_CRR_CRG + isc->offsets.csc,
    71			     0x70 | (0xFA2 << 16));
    72		regmap_write(regmap, ISC_CSC_CRB_OCR + isc->offsets.csc,
    73			     0xFEE | (0x80 << 16));
    74	}
    75	
  > 76	void isc_sama5d2_config_cbc(struct isc_device *isc)
    77	{
    78		struct regmap *regmap = isc->regmap;
    79	
    80		regmap_write(regmap, ISC_CBC_BRIGHT, isc->ctrls.brightness);
    81		regmap_write(regmap, ISC_CBC_CONTRAST, isc->ctrls.contrast);
    82	}
    83	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37908 bytes)