linux-kernel - Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Apr 2021 08:02:30 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        lukasz.luba@....com, rafael@...nel.org
Subject: Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote:
> 
> Hi Greg,
> 
> On 31/03/2021 20:06, Greg KH wrote:
> > On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote:
> >> +struct dtpm *dtpm_lookup(const char *name);
> >> +
> >> +int dtpm_add(const char *name, struct dtpm *dtpm);
> >> +
> >> +void dtpm_del(const char *name);
> > 
> > You can not add new kernel apis that have no user.  How do you know if
> > they actually work or not?  We have no idea as we do not see anyone
> > using them :(
> > 
> > So no need to add things with no user, feel free to just drop this patch
> > until you have one.
> 
> I've sent a couple of patches [1] on top of the previous series. I'm
> finishing to respin it against this new one.
> 
>   -- Daniel
> 
> [1] https://lkml.org/lkml/2021/3/12/1514

Please use lore.kernel.org, we do not control lkml and it has been down
in the past and it's impossible to reply from.

Please always provide a user of a function in the patch series,
otherwise you will end up with comments like mine above.

thanks,

greg k-h