linux-kernel - Re: [PATCH v2] fs: Improve eventpoll logging to stop indicting timerfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202104011400.DGEzXoIr-lkp@intel.com>
Date:   Thu, 1 Apr 2021 14:44:45 +0800
From:   kernel test robot <lkp@...el.com>
To:     Manish Varma <varmam@...gle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     kbuild-all@...ts.01.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Manish Varma <varmam@...gle.com>,
        Kelly Rossmoyer <krossmo@...gle.com>
Subject: Re: [PATCH v2] fs: Improve eventpoll logging to stop indicting
 timerfd

Hi Manish,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc5 next-20210331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Manish-Varma/fs-Improve-eventpoll-logging-to-stop-indicting-timerfd/20210401-101954
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c
config: um-randconfig-r006-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/49789288695d81f196d99fadd89b5101b26bca8b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Manish-Varma/fs-Improve-eventpoll-logging-to-stop-indicting-timerfd/20210401-101954
        git checkout 49789288695d81f196d99fadd89b5101b26bca8b
        # save the attached .config to linux build tree
        make W=1 ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
   fs/eventpoll.c: In function 'ep_create_wakeup_source':
>> fs/eventpoll.c:1375:26: error: 'wakesource_create_id' undeclared (first use in this function); did you mean 'wakeup_source_create'?
    1375 |  id = atomic_inc_return(&wakesource_create_id);
         |                          ^~~~~~~~~~~~~~~~~~~~
         |                          wakeup_source_create
   fs/eventpoll.c:1375:26: note: each undeclared identifier is reported only once for each function it appears in


vim +1375 fs/eventpoll.c

  1357	
  1358	static int ep_create_wakeup_source(struct epitem *epi)
  1359	{
  1360		struct name_snapshot n;
  1361		struct wakeup_source *ws;
  1362		pid_t task_pid;
  1363		char buf[64];
  1364		int id;
  1365	
  1366		task_pid = task_pid_nr(current);
  1367	
  1368		if (!epi->ep->ws) {
  1369			snprintf(buf, sizeof(buf), "epoll:%d", task_pid);
  1370			epi->ep->ws = wakeup_source_register(NULL, buf);
  1371			if (!epi->ep->ws)
  1372				return -ENOMEM;
  1373		}
  1374	
> 1375		id = atomic_inc_return(&wakesource_create_id);
  1376		take_dentry_name_snapshot(&n, epi->ffd.file->f_path.dentry);
  1377		snprintf(buf, sizeof(buf), "epollitem%d:%d.%s", id, task_pid, n.name.name);
  1378		ws = wakeup_source_register(NULL, buf);
  1379		release_dentry_name_snapshot(&n);
  1380	
  1381		if (!ws)
  1382			return -ENOMEM;
  1383		rcu_assign_pointer(epi->ws, ws);
  1384	
  1385		return 0;
  1386	}
  1387	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (14435 bytes)