linux-kernel - Re: [PATCH] misc: vmw_vmci: initialize payload passed to vmci_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YGVx+A7VyV7LVLPW@kroah.com>
Date:   Thu, 1 Apr 2021 09:10:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     George Zhang <georgezhang@...are.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: vmw_vmci: initialize payload passed to
 vmci_send_datagram()

On Thu, Apr 01, 2021 at 03:53:02PM +0900, Tetsuo Handa wrote:
> On 2021/04/01 15:18, Greg Kroah-Hartman wrote:
> > On Thu, Apr 01, 2021 at 02:57:47PM +0900, Tetsuo Handa wrote:
> >> KMSAN complains that the vmci_use_ppn64() == false path in
> >> vmci_dbell_register_notification_bitmap() left upper 32bits of
> >> bitmap_set_msg.bitmap_ppn64 member uninitialized.
> >>
> >> KMSAN also complains that vmci_check_host_caps() left the payload part
> >> of check_msg uninitialized.
> >>
> > 
> > What commit does this "fix"?  Can you resend with a proper "Fixes:" tag
> > so we know where it needs to be backported to?
> 
> It seems that this problem exists since the introduction.
> 
>   commit 83e2ec765be03e8a8a07619e65df70b48a1db023
>   Author: George Zhang <georgezhang@...are.com>
>   Date:   Tue Jan 8 15:53:51 2013 -0800
>   
>       VMCI: doorbell implementation.
>   
>   commit 1f166439917b69d3046e2e49fe923579d9181212
>   Author: George Zhang <georgezhang@...are.com>
>   Date:   Tue Jan 8 15:55:32 2013 -0800
>   
>       VMCI: guest side driver implementation.
> 
> But this patch should be safe to backport to as old as possible, for
> this patch is merely explicitly initializing variables.

Great, can you please resend with the Fixes: tag and a cc: stable in the
signed-off-by area as well when you resend these as a 2 patch series?

thanks,

greg k-h