linux-kernel - Re: [PATCH] tools: perf: util: Remove duplicate struct declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Apr 2021 16:19:38 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [PATCH] tools: perf: util: Remove duplicate struct declaration

Hello,

On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@...o.com> wrote:
>
> struct target is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

I think we can move all the forward declarations to the top
(and sort them) as well.

Thanks,
Namhyung


> ---
>  tools/perf/util/evsel.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 6026487353dd..998e5b806696 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -157,7 +157,6 @@ struct perf_missing_features {
>  extern struct perf_missing_features perf_missing_features;
>
>  struct perf_cpu_map;
> -struct target;
>  struct thread_map;
>  struct record_opts;
>
> --
> 2.25.1
>