linux-kernel - RE: [PATCH] cifsd: fix memory leak when loop ends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <003901d726cf$6b75d890$426189b0$@samsung.com>
Date:   Thu, 1 Apr 2021 17:17:13 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Muhammad Usama Anjum'" <musamaanjum@...il.com>,
        "'Sergey Senozhatsky'" <sergey.senozhatsky@...il.com>,
        "'Steve French'" <sfrench@...ba.org>,
        "'Hyunchul Lee'" <hyc.lee@...il.com>,
        "'open list:COMMON INTERNET FILE SYSTEM SERVER \(CIFSD\)'" 
        <linux-cifs@...r.kernel.org>,
        "'open list:COMMON INTERNET FILE SYSTEM SERVER \(CIFSD\)'" 
        <linux-cifsd-devel@...ts.sourceforge.net>,
        "'open list'" <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <colin.king@...onical.com>,
        <dan.carpenter@...cle.com>
Subject: RE: [PATCH] cifsd: fix memory leak when loop ends

> 
> Memory is being allocated and if veto_list is zero, the loop breaks without cleaning up the allocated
> memory. In this patch, the length check has been moved before allocation. If loop breaks, the memory
> isn't allocated in the first place. Thus the memory is being protected from leaking.
> 
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@...il.com>
I will apply. Thanks for your patch!