linux-kernel - Re:Re: [PATCH] drm/ttm: cleanup coding style a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AJ6AJwDpDj4OHkToJ0s9uKqk.3.1617242344627.Hmail.bernard@vivo.com>
Date:   Thu, 1 Apr 2021 09:59:04 +0800 (GMT+08:00)
From:   Bernard <bernard@...o.com>
To:     Christian König <christian.koenig@....com>
Cc:     Huang Rui <ray.huang@....com>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re:Re: [PATCH] drm/ttm: cleanup coding style a bit



From: "Christian König" <christian.koenig@....com>
Date: 2021-03-31 21:15:22
To:  Bernard Zhao <bernard@...o.com>,Huang Rui <ray.huang@....com>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,dri-devel@...ts.freedesktop.org,linux-kernel@...r.kernel.org
Cc:  opensource.kernel@...o.com
Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit>Am 31.03.21 um 15:12 schrieb Bernard Zhao:
>> Fix sparse warning:
>> drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static?
>> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static?
>>
>> Signed-off-by: Bernard Zhao <bernard@...o.com>
>
>You are based on an outdated branch, please rebase on top of drm-misc-next.
>

Hi

Sure, thanks for your review！
I will fix this and resubmit this patch.

BR//Bernard

>Regards,
>Christian.
>
>> ---
>>   drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>> index 101a68dc615b..eab21643edfb 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
>>   /*
>>    * ttm_global_mutex - protecting the global BO state
>>    */
>> -DEFINE_MUTEX(ttm_global_mutex);
>> -unsigned ttm_bo_glob_use_count;
>> +static DEFINE_MUTEX(ttm_global_mutex);
>> +static unsigned int ttm_bo_glob_use_count;
>>   struct ttm_bo_global ttm_bo_glob;
>>   EXPORT_SYMBOL(ttm_bo_glob);
>>   
>