linux-kernel - Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca1b9b0c-55f9-025d-558b-1b2b6c866d12@samba.org>
Date:   Thu, 1 Apr 2021 14:50:39 +0200
From:   Ralph Boehme <slow@...ba.org>
To:     Namjae Jeon <linkinjeon@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     COMMON INTERNET FILE SYSTEM SERVER <linux-cifs@...r.kernel.org>,
        COMMON INTERNET FILE SYSTEM SERVER 
        <linux-cifsd-devel@...ts.sourceforge.net>,
        kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Steve French <sfrench@...ba.org>, colin.king@...onical.com,
        Muhammad Usama Anjum <musamaanjum@...il.com>
Subject: Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory
 allocated by kzalloc

Am 4/1/21 um 2:43 PM schrieb Namjae Jeon:
> 2021-04-01 20:50 GMT+09:00, Dan Carpenter <dan.carpenter@...cle.com>:
>> On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote:
>>> kfree should be used to free memory allocated by kzalloc to avoid
>>> any overhead and for maintaining consistency.
>>>
>>> Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")
>>> Signed-off-by: Muhammad Usama Anjum <musamaanjum@...il.com>
>>> ---
>>> This one place was left in earlier patch. I've already received
>>> responsse on that patch. I'm sending a separate patch.
>>>
>>>   fs/cifsd/transport_tcp.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/cifsd/transport_tcp.c b/fs/cifsd/transport_tcp.c
>>> index 67163efcf472..040881893417 100644
>>> --- a/fs/cifsd/transport_tcp.c
>>> +++ b/fs/cifsd/transport_tcp.c
>>> @@ -551,7 +551,7 @@ void ksmbd_tcp_destroy(void)
>>>   	list_for_each_entry_safe(iface, tmp, &iface_list, entry) {
>>>   		list_del(&iface->entry);
>>>   		kfree(iface->name);
>>> -		ksmbd_free(iface);
>>> +		kfree(iface);
>>
>> We should just delete the ksmbd_free() function completely.
> Yes, I have added your review comment about this to my todo-list.
> I will do that.
>>
>> I think that cifsd is being re-written though so it might not be worth
>> it.
> Right.

fwiw, while at it what about renaming everything that still references 
"cifs" to "smb" ? This is not the 90's... :)

Cheers!
-slow



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)