linux-kernel - Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YGUtoI+rsdm1cKWr@zeniv-ca.linux.org.uk>
Date:   Thu, 1 Apr 2021 02:19:12 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Jonathan Corbet <corbet@....net>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation

On Wed, Mar 31, 2021 at 02:24:18PM -0600, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@...radead.org> writes:
> 
> > Fix kernel-doc warnings in fs/namespace.c:
> >
> > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree'
> > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree'
> > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount'
> >
> > Also convert path_is_mountpoint() comments to kernel-doc.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Al Viro <viro@...iv.linux.org.uk>
> > Cc: Jonathan Corbet <corbet@....net>
> > Cc: linux-doc@...r.kernel.org
> > ---
> > Jon, Al has OK-ed you to merge this patch (and the next one, please).
> >
> >  fs/namespace.c |   14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> An actual acked-by would have been nice, oh well.  Meanwhile, I've
> applied them with fixes to the typos in both changelogs :)

Generally speaking, I'm only glad to leave handling kernel-doc patches
to somebody else, especially when they are that trivial ;-)

Anyway,
Acked-by: Al Viro <viro@...iv.linux.org.uk>