linux-kernel - Re: [External] Re: [PATCH v2] writeback: fix obtain a reference to a freeing memcg css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGXaqcLOHjlCkNkt@dhcp22.suse.cz>
Date:   Thu, 1 Apr 2021 16:37:29 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Tejun Heo <tj@...nel.org>, axboe@...com,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [External] Re: [PATCH v2] writeback: fix obtain a reference to a
 freeing memcg css

On Thu 01-04-21 21:59:13, Muchun Song wrote:
> On Thu, Apr 1, 2021 at 6:26 PM Michal Hocko <mhocko@...e.com> wrote:
[...]
> > Even if the css ref count is not really necessary it shouldn't cause any
> > harm and it makes the code easier to understand. At least a comment
> > explaining why that is not necessary would be required without it
> 
> OK. I will add a comment here to explain why we need to hold a
> ref.

I do not think this is necessary. Taking the reference is a standard
way and I am not sure it requires a comment. I meant to say that not
having a reference should really have a comment explaining why.

Thanks!
-- 
Michal Hocko
SUSE Labs