linux-kernel - [PATCH -next] driver: aoe: use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 2 Apr 2021 15:33:11 +0800
From:   Zucheng Zheng <zhengzucheng@...wei.com>
To:     <justin@...aid.com>, <axboe@...nel.dk>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hucool.lihua@...wei.com>
Subject: [PATCH -next] driver: aoe: use DEFINE_SPINLOCK() for spinlock

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zucheng Zheng <zhengzucheng@...wei.com>
---
 drivers/block/aoe/aoenet.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
index 63773a90581d..46cce83c155d 100644
--- a/drivers/block/aoe/aoenet.c
+++ b/drivers/block/aoe/aoenet.c
@@ -47,7 +47,7 @@ static int __init aoe_iflist_setup(char *str)
 __setup("aoe_iflist=", aoe_iflist_setup);
 #endif
 
-static spinlock_t txlock;
+static DEFINE_SPINLOCK(txlock);
 static struct sk_buff_head skbtxq;
 
 /* enters with txlock held */
@@ -201,7 +201,6 @@ aoenet_init(void)
 {
 	skb_queue_head_init(&skbtxq);
 	init_waitqueue_head(&txwq);
-	spin_lock_init(&txlock);
 	kts.lock = &txlock;
 	kts.fn = tx;
 	kts.waitq = &txwq;
-- 
2.17.1