linux-kernel - Re: [PATCH 1/2] mmc: block: Issue flush only if allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB6575658643D2344B4AE027C8FC7A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Fri, 2 Apr 2021 07:46:51 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "adrian.hunter@...el.com" <adrian.hunter@...el.com>
CC:     Avri Altman <Avri.Altman@....com>,
        "bpeter@...x.com" <bpeter@...x.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
Subject: Re: [PATCH 1/2] mmc: block: Issue flush only if allowed

>> @@ -1473,6 +1473,9 @@ static int mmc_blk_cqe_issue_flush(struct mmc_queue *mq, struct request *req)
>>  	struct mmc_queue_req *mqrq = req_to_mmc_queue_req(req);
>>  	struct mmc_request *mrq = mmc_blk_cqe_prep_dcmd(mqrq, req);
>>  
>> +	if (mmc_card_mmc(mq->card) && !mmc_flush_allowed(mq->card))
>> +		return 0;

> Returning 0 means the flush was issued successfully. i.e. it is in
> flight.
>
> Instead, a call to blk_mq_end_request(req, BLK_STS_OK) is needed,
> and mmc_blk_mq_issue_rq() must be amended so that it will return
> MMC_REQ_DONE for this case.
Done.

Thanks,
Avri