linux-kernel - Re: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210401140204.bikghitzypf7fraf@ti.com>
Date:   Thu, 1 Apr 2021 09:02:04 -0500
From:   Benoit Parrot <bparrot@...com>
To:     Yang Yingliang <yangyingliang@...wei.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <mchehab@...nel.org>
Subject: Re: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call
 in sc_create()

Yang,

Thank you for the patch.

Yang Yingliang <yangyingliang@...wei.com> wrote on Thu [2021-Apr-01 18:30:15 +0800]:
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/media/platform/ti-vpe/sc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c
> index 98f95082a6fd..0202d278523f 100644
> --- a/drivers/media/platform/ti-vpe/sc.c
> +++ b/drivers/media/platform/ti-vpe/sc.c
> @@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name)
>  	}
>  
>  	sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
> -	if (IS_ERR(sc->base)) {
> -		dev_err(&pdev->dev, "failed to ioremap\n");
> +	if (IS_ERR(sc->base))
>  		return ERR_CAST(sc->base);
> -	}

Reviewed-by: Benoit Parrot <bparrot@...com>

>  
>  	return sc;
>  }
> -- 
> 2.25.1
>