linux-kernel - Re: [PATCH] Revert "usb: dwc3: gadget: Prevent EP queuing while stopping transfers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7a6165055ea857a6e0f86591f9235671fb11d02.camel@puri.sm>
Date:   Fri, 02 Apr 2021 11:27:25 +0200
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Wesley Cheng <wcheng@...eaurora.org>, gregkh@...uxfoundation.org,
        balbi@...nel.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] Revert "usb: dwc3: gadget: Prevent EP queuing while
 stopping transfers"

Am Donnerstag, dem 01.04.2021 um 11:09 -0700 schrieb Wesley Cheng:
> 
> 
> On 4/1/2021 4:55 AM, Martin Kepplinger wrote:
> > This reverts commit 9de499997c3737e0c0207beb03615b320cabe495.
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> > ---
> > 
> > I more or less blindly report:
> > commit 9de499997c ("usb: dwc3: gadget: Prevent EP queuing while
> > stopping
> > transfers") results in the below error every time I connect the
> > type-c
> > connector to the dwc3, configured with serial and ethernet gadgets.
> > 
> > fyi, I apply the following to dwc3 on this port:
> > dr_mode =
> > "otg";                                                        
> > snps,dis_u3_susphy_quirk;                                          
> >      
> > hnp-
> > disable;                                                           
> > srp-
> > disable;                                                           
> > adp-
> > disable;                                                           
> > usb-role-switch;
> > 
> > v5.12-rc5 does not have this error so I'm not sure whether it's
> > more appropriate to add something to dwc3 than reverting. I hope
> > usb
> > people to know better and maybe even see the problem.
> > 
> > thanks,
> >                                martin
> > 
> Hi Martin,
> 
> This has been fixed with the below:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-linus&id=5aef629704ad4d983ecf5c8a25840f16e45b6d59
> 
> Can you pull that in and give it a try?
> 
> Thanks
> Wesley Cheng

yes, that's a fix for my problem (and what I secretly had hoped to get
:). Thank you very much. In case it helps:

Tested-by: Martin Kepplinger <martin.kepplinger@...i.sm>