linux-kernel - Re: [PATCH] firmware: qcom-scm: Fix QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Apr 2021 16:25:56 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     He Ying <heying24@...wei.com>
Cc:     nsaenzjulienne@...e.de, sudeep.holla@....com,
        linus.walleij@...aro.org, robh@...nel.org, john.stultz@...aro.org,
        colin.king@...onical.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration

On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote:
> When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC
> is not set, compiling errors are encountered as follows:
> 
> drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk':
> qcom_scm-smc.c:(.text+0x36): undefined reference to `__arm_smccc_smc'
> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call':
> qcom_scm-legacy.c:(.text+0xe2): undefined reference to `__arm_smccc_smc'
> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call_atomic':
> qcom_scm-legacy.c:(.text+0x1f0): undefined reference to `__arm_smccc_smc'
> 
> So add dependency on HAVE_ARM_SMCCC in QCOM_SCM configuration.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: He Ying <heying24@...wei.com>
> ---
>  drivers/firmware/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

What commit caused this problem to show up?  Please add a "Fixes:" tag
in here and resend.

thanks,

greg k-h