linux-kernel - Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b93bf84f-73fd-f0f9-c25b-d7063be76987@wanyeetech.com>
Date:   Fri, 2 Apr 2021 23:30:32 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Wolfram Sang <wsa@...nel.org>
Cc:     paul@...pouillou.net, stable@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, sernia.zhou@...mail.com
Subject: Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

Hi Wolfram,

On 2021/3/31 下午3:18, Wolfram Sang wrote:
> Hi,
>
>>> Any write operation? I wonder then why nobody noticed before?
>>
>> The standard I2C communication should look like this:
>>
>> Read:
>>
>> device_addr + w, reg_addr, device_addr + r, data;
>>
>> Write:
>>
>> device_addr + w, reg_addr, data;
>>
>>
>> But without this patch, it looks like this:
>>
>> Read:
>>
>> device_addr + w, reg_addr, device_addr + r, data;
>>
>> Write:
>>
>> device_addr + w, reg_addr, device_addr + w, data;
>>
>> This is clearly not correct.
> Thanks for the additional information! I understand now. I added a bit
> of this to the commit message of v2 to explain the situation.
>

Thanks!


Best regards!