linux-kernel - Re: [PATCH] fs: cifs: Remove unnecessary struct declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5ms-rZPZi9TLE6f4Xoc33B51YKbuT+pVy8xaeNFzg9jLVg@mail.gmail.com>
Date:   Fri, 2 Apr 2021 10:42:09 -0500
From:   Steve French <smfrench@...il.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [PATCH] fs: cifs: Remove unnecessary struct declaration

merged into cifs-2.6.git for-next

On Thu, Apr 1, 2021 at 2:52 AM Wan Jiabing <wanjiabing@...o.com> wrote:
>
> struct cifs_readdata is declared twice. One is declared
> at 208th line.
> And struct cifs_readdata is defined blew.
> The declaration here is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  fs/cifs/cifsglob.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 67c056a9a519..ec824ab8c5ca 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
>         bool                    direct_io;
>  };
>
> -struct cifs_readdata;
> -
>  /* asynchronous read support */
>  struct cifs_readdata {
>         struct kref                     refcount;
> --
> 2.25.1
>


-- 
Thanks,

Steve