linux-kernel - Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <614f4c0f-deaa-ad3a-09d1-ac6e8ec2d143@acm.org>
Date:   Fri, 2 Apr 2021 09:03:18 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Luo Jiaxing <luojiaxing@...wei.com>, jinpu.wang@...ud.ionos.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

On 4/2/21 2:08 AM, Luo Jiaxing wrote:
> -static struct flash_command flash_command_table[] =
> -{
> +static struct flash_command flash_command_table[] = {
>       {"set_nvmd",    FLASH_CMD_SET_NVMD},
>       {"update",      FLASH_CMD_UPDATE},
>       {"",            FLASH_CMD_NONE} /* Last entry should be NULL. */

Can 'flash_command_table' be declared const?

> -static struct error_fw flash_error_table[] =
> -{
> +static struct error_fw flash_error_table[] = {
>       {"Failed to open fw image file",	FAIL_OPEN_BIOS_FILE},
>       {"image header mismatch",		FLASH_UPDATE_HDR_ERR},
>       {"image offset mismatch",		FLASH_UPDATE_OFFSET_ERR},

Can 'flash_error_table' be declared const?

Thanks,

Bart.