linux-kernel - Re: [PATCH -next] gpio: GPIO_SCH: depends on PCI same as LPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <72016dea-515d-e254-cda5-adc097635e19@infradead.org>
Date:   Fri, 2 Apr 2021 09:11:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Denis Turischev <denis@...pulab.co.il>
Subject: Re: [PATCH -next] gpio: GPIO_SCH: depends on PCI same as LPC_SCH

On 4/2/21 2:00 AM, Andy Shevchenko wrote:
> On Friday, April 2, 2021, Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> Since LPC_SCH depends on PCI, GPIO_SCH must also depend on PCI
>> to prevent kconfig warning and build errors:
>>
>> WARNING: unmet direct dependencies detected for LPC_SCH
>>   Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
>>   Selected by [y]:
>>   - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST
>> [=n]) && ACPI [=y]
>>
>> and
>>
>> ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or
>> storage class
>>  module_pci_driver(lpc_sch_driver);
>>  ^~~~~~~~~~~~~~~~~
>> ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in
>> declaration of ‘module_pci_driver’ [-Werror=implicit-int]
>> ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types)
>> in function declaration
>> ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but
>> not used [-Wunused-variable]
>>  static struct pci_driver lpc_sch_driver = {
>>                           ^~~~~~~~~~~~~~
>>
>>
> Thanks for catching this!
> But I am wondering if this actually should be fixed by switching to depends
> on LPC_SCH. What do you think?
> 

Sounds good to me. I'll send v2 like that.
Thanks.

> 
> 
>> Fixes: 6c46215d6b62 ("gpio: sch: Hook into ACPI GPE handler to catch GPIO
>> edge events")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> Cc: linux-gpio@...r.kernel.org
>> Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>
>> Cc: Denis Turischev <denis@...pulab.co.il>
>> ---
>>  drivers/gpio/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20210401.orig/drivers/gpio/Kconfig
>> +++ linux-next-20210401/drivers/gpio/Kconfig
>> @@ -860,7 +860,7 @@ config GPIO_IT87
>>
>>  config GPIO_SCH
>>         tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"
>> -       depends on (X86 || COMPILE_TEST) && ACPI
>> +       depends on (X86 || COMPILE_TEST) && ACPI && PCI
>>         select GPIOLIB_IRQCHIP
>>         select MFD_CORE
>>         select LPC_SCH
>>
> 
> 


-- 
~Randy